Review Request: Remove now obsolete method in account-filter-model Removed a weird hack in the contact list main app.

[David Edmundson]

> On June 16, 2011, 11:39 a.m., Martin Klapetek wrote:
> > If you are sure, that the list does not crash when switching to groups and back (as it used to back in the days, may be very well fixed now), then I'm ok with it.

I can see why you might have needed it with the old account-filter code. This new account filter code is a bit more robust. I tested the hell out of it (trying to reproduce that other crash), I haven't managed to make mine break.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101641/#review3931
-----------------------------------------------------------


On June 16, 2011, 11:34 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101641/
> -----------------------------------------------------------
> 
> (Updated June 16, 2011, 11:34 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Remove now obsolete method in account-filter-model Removed a weird hack in the contact list main app.
> 
> 
> Diffs
> -----
> 
>   account-filter-model.h 1e30a250ec03e888fbbd76ff2fb279b67af25227 
>   account-filter-model.cpp d86b34038c2c847596fc271b1abdb4a3ca27f09a 
>   main-widget.cpp 1f81b19566a97502c81ad81c2b81d56fc08d5cd4 
> 
> Diff: http://git.reviewboard.kde.org/r/101641/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110616/7fbacd48/attachment-0001.htm