Review Request: Complete tidy up of filterAcceptsRow in AccountFilterModel

Martin Klapetek martin.klapetek at gmail.com
Thu Jun 16 10:24:55 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101638/#review3920
-----------------------------------------------------------

Ship it!


Good job Mr. Edmundson, nicely done.


account-filter-model.cpp
<http://git.reviewboard.kde.org/r/101638/#comment3197>

    Unnecessarily big whitespace ;)



account-filter-model.cpp
<http://git.reviewboard.kde.org/r/101638/#comment3196>

    Unnecessarily big whitespace again ;)


- Martin


On June 15, 2011, 10:52 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101638/
> -----------------------------------------------------------
> 
> (Updated June 15, 2011, 10:52 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Complete tidy up of filterAcceptsRow in AccountFilterModel
> 
> 
> Diffs
> -----
> 
>   account-filter-model.h 1e30a250ec03e888fbbd76ff2fb279b67af25227 
>   account-filter-model.cpp d86b34038c2c847596fc271b1abdb4a3ca27f09a 
> 
> Diff: http://git.reviewboard.kde.org/r/101638/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110616/eaee3e4d/attachment-0001.htm 


More information about the KDE-Telepathy mailing list