Review Request: Complete tidy up of filterAcceptsRow in AccountFilterModel

David Edmundson kde at davidedmundson.co.uk
Thu Jun 16 00:50:24 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101637/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

Complete tidy up of filterAcceptsRow in AccountFilterModel

Refactor filterOfflineUsers to showOfflineUsers  - This commit changes the nature of the Show/Hide Offline Users action button  - Pushing the button in now shows the offline users instead of hiding them  - String change : "Show/Hide offline users" -> "Hide/Show offline users"


Diffs
-----

  CMakeLists.txt b68d1366bab304c807546ed325ac94a404a21285 
  abstract-contact-delegate.cpp PRE-CREATION 
  account-filter-model.h 659135506aa3f101e8cc8b9cefc0b4870ca35b8a 
  account-filter-model.cpp 75f2126bc36b9cde8d22002a11966ffc7479d408 
  accounts-model-item.h 54d8f87ace366ee8b53e21c4cd0494de23d359b1 
  accounts-model-item.cpp d6fa8aaa439d98757eade6f79e046edc2ce6c8e0 
  accounts-model.h 0eda7f406dde9b3c1443fb0f4b1656fbb878efad 
  accounts-model.cpp c342c5bfcb89e1d9778556cbd4604f8e03830420 
  cmake/modules/FindTelepathyQt4.cmake b4d486863d1b17ddc3152a6064e1a92f6e153d3e 
  groups-model-item.h PRE-CREATION 
  groups-model-item.cpp PRE-CREATION 
  groups-model.cpp PRE-CREATION 
  main-widget.h c103a66e4c92b93a933fe02c82b5462c09740e85 
  main-widget.cpp b929572ff47e7fc4a34e385525d0aab458909ffb 
  main-widget.ui cf1dee4224870e34e2d14034a7c3eeee5f45cddb 
  telepathy-kde-contactlist.notifyrc PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/101637/diff


Testing
-------


Thanks,

David

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110615/ab2b2011/attachment.htm 


More information about the KDE-Telepathy mailing list