Review Request: Refactor filterOfflineUsers to showOfflineUsers

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101630/#review3911
-----------------------------------------------------------

Ship it!


Nice one!

- Martin


On June 15, 2011, 2:14 p.m., Rohan Garg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101630/
> -----------------------------------------------------------
> 
> (Updated June 15, 2011, 2:14 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Refactor filterOfflineUsers to showOfflineUsers   
> - This commit changes the nature of the Show/Hide Offline Users action button  
> - Pushing the button in now shows the offline users instead of hiding them 
> - String change : "Show/Hide offline users" -> "Hide/Show offline users"
> 
> 
> Diffs
> -----
> 
>   account-filter-model.h 007c2a9881141ce1999dd1d598a619d2f7e5fd8b 
>   account-filter-model.cpp d30b20861b4dd9853b543df17b7f8475cf7865df 
>   main-widget.h abee064e9c2d3353f6f2d7bfebc32a61a004f0df 
>   main-widget.cpp 65fff9326aed047e6fd815586f12e310c02b2595 
> 
> Diff: http://git.reviewboard.kde.org/r/101630/diff
> 
> 
> Testing
> -------
> 
> Yes, clicking the "Hide/Show offline users" now shows the offline users when it's in the 'Pressed' state, does not show them otherwise
> 
> 
> Thanks,
> 
> Rohan
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110615/cafd7cf8/attachment.htm