Review Request: Use latest dir for file transfer when using kde-tp

George Kiagiadakis kiagiadakis.george at gmail.com
Wed Jun 15 10:59:21 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101624/#review3894
-----------------------------------------------------------



main-widget.cpp
<http://git.reviewboard.kde.org/r/101624/#comment3188>

    1) Please split this line into multiple lines. It's hard to read when there is a lot of characters in one line.
    
    2) Maybe the key should be something like "FileTransferLastDirectory" instead of "KdeTelepathyFileTransfer", which doesn't really mean anything to me. Note that this is recorded as a key in the config file, so imho it should be readable in case someone wishes to edit the config file directly.


- George


On June 15, 2011, 12:30 a.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101624/
> -----------------------------------------------------------
> 
> (Updated June 15, 2011, 12:30 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Added standard way of using last dir the user sent a file from when using kde-telepathy
> 
> 
> Diffs
> -----
> 
>   main-widget.cpp 6481ad2 
> 
> Diff: http://git.reviewboard.kde.org/r/101624/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110615/f830c1c8/attachment.htm 


More information about the KDE-Telepathy mailing list