Review Request: add new toolbuttons to chat (part 2 of 3)

Francesco Nwokeka francesco.nwokeka at gmail.com
Wed Jun 15 02:17:19 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101622/
-----------------------------------------------------------

(Updated June 15, 2011, 12:17 a.m.)


Review request for Telepathy.


Changes
-------

Updated patch.


Summary
-------

Patch 2 of 3.
This patch connects the buttons with the corrisponding signals. It also implements a plasma notification system to notify the user on errors given by these buttons (took procedure from martin's contactlist).
Buttons implemented are :
~ video call
~ audio call
~ send file

The invite to chat button will remain disabled (from next patch) until group support will be ok. After these three patches i will work on that feature again.


Diffs (updated)
-----

  app/CMakeLists.txt dd1a23a 
  app/chat-window.h 3db916e 
  app/chat-window.cpp 7fe5f51 
  app/telepathy-kde-text-ui.notifyrc PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/101622/diff


Testing
-------

Used the buttons to start the different channels and got errors for all apart for the file transfer because other features are not implemented. Plasma norification worked well.


Thanks,

Francesco

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110615/83a26e7a/attachment-0001.htm 


More information about the KDE-Telepathy mailing list