Review Request: add new toolbuttons to chat (part 2 of 3)

[Francesco Nwokeka]

> On June 14, 2011, 9:30 p.m., David Edmundson wrote:
> > app/chat-window.h, line 41
> > <http://git.reviewboard.kde.org/r/101622/diff/1/?file=24489#file24489line41>
> >
> >     Nothing uses this, making the whole enum a bit pointless.

I added this for future use. Should i still remove it?


> On June 14, 2011, 9:30 p.m., David Edmundson wrote:
> > app/chat-window.cpp, line 221
> > <http://git.reviewboard.kde.org/r/101622/diff/1/?file=24490#file24490line221>
> >
> >     What happens in multi-user chats?
> >     I think this returns an invalid contact.
> >     
> >     I think we need to:
> >     1) only enable the buttons if there is a single contact mode.  (for now)
> >     2) Double check on the start of startFileTransfer startXyz that contact exists.

Ok, the check for nable/disable button will be done in patch 3 of the series. I'll add an extra check in the ChatWindow::onFileTransferTriggered function to be sure to send a file to only one contact.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101622/#review3888
-----------------------------------------------------------


On June 14, 2011, 9:06 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101622/
> -----------------------------------------------------------
> 
> (Updated June 14, 2011, 9:06 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Patch 2 of 3.
> This patch connects the buttons with the corrisponding signals. It also implements a plasma notification system to notify the user on errors given by these buttons (took procedure from martin's contactlist).
> Buttons implemented are :
> ~ video call
> ~ audio call
> ~ send file
> 
> The invite to chat button will remain disabled (from next patch) until group support will be ok. After these three patches i will work on that feature again.
> 
> 
> Diffs
> -----
> 
>   app/CMakeLists.txt dd1a23a 
>   app/chat-window.h 3db916e 
>   app/chat-window.cpp 7fe5f51 
> 
> Diff: http://git.reviewboard.kde.org/r/101622/diff
> 
> 
> Testing
> -------
> 
> Used the buttons to start the different channels and got errors for all apart for the file transfer because other features are not implemented. Plasma norification worked well.
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110614/a39c3cec/attachment.htm