Review Request: Contact-Caps support in Nepomuk Service

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101613/#review3881
-----------------------------------------------------------

Ship it!


Looks good to me, just a question...


nepomuk-storage.cpp
<http://git.reviewboard.kde.org/r/101613/#comment3177>

    Are those capabilities already merged in sdo?


- Daniele Elmo


On June 14, 2011, 2:07 p.m., George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101613/
> -----------------------------------------------------------
> 
> (Updated June 14, 2011, 2:07 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Reinstate Contact-Capabilities support in the Telepathy Nepomuk Service.
> 
> 
> This addresses bug https://bugs.kde.org/show_bug.cgi?id=270865.
>     http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=270865
> 
> 
> Diffs
> -----
> 
>   abstract-storage.h 7d1be9b96711500ddd2ab5b6d9aa8791e51bcea1 
>   account.h b57ebf881e1bd661bd8db069cc3f5147ce10b515 
>   account.cpp e0cfdf0931c75126339e18fb2458a93d510b6e28 
>   contact.h ccc482aa36c3d8e38cfa89608043f198ef8be674 
>   contact.cpp bc5a29100e380bbcb7ae48930813d19842b0a836 
>   controller.cpp f320326534c8b76ea73097c906d82c2b90a35f22 
>   nepomuk-storage.h 216239371b0656dff61c4a189a709703094b7418 
>   nepomuk-storage.cpp 7d154494b759e2b9bca95d086f164f1a71ab1095 
>   tests/controller-test.h cd85a675d731b43c0960e0b5ba3fb02d8aacade7 
>   tests/storage-test.h ab5f05f2e5faf6b0710c2dfd9f8d3f21ae06d330 
>   tests/storage-test.cpp 2ff9428f57f2515c60c9fe7fb24c46d9f6907b7d 
> 
> Diff: http://git.reviewboard.kde.org/r/101613/diff
> 
> 
> Testing
> -------
> 
> Unit tests (including new one for this feature) all pass.
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110614/c5ba3447/attachment.htm