Review Request: Add group online/total users count

David Edmundson kde at davidedmundson.co.uk
Thu Jun 9 12:54:05 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101559/#review3802
-----------------------------------------------------------

Ship it!



account-filter-model.cpp
<http://git.reviewboard.kde.org/r/101559/#comment3106>

    Don't need this now.



account-filter-model.cpp
<http://git.reviewboard.kde.org/r/101559/#comment3107>

    We should rewrite this whole method at some point, it's quite a mess.


- David


On June 9, 2011, 10:48 a.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101559/
> -----------------------------------------------------------
> 
> (Updated June 9, 2011, 10:48 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch adds numbers to group headers in "(online users/total users in group)" scheme. Also it allows to filter out empty groups.
> 
> 
> Diffs
> -----
> 
>   abstract-contact-delegate.cpp db2f3de 
>   account-filter-model.cpp 2542ae6 
>   accounts-model-item.h 54d8f87 
>   accounts-model-item.cpp 6facdea 
>   accounts-model.h 96e8994 
>   accounts-model.cpp 47fc697 
>   groups-model-item.h 63f3973 
>   groups-model-item.cpp 6eec952 
>   groups-model.cpp 46631e4 
>   main-widget.cpp 7c65760 
> 
> Diff: http://git.reviewboard.kde.org/r/101559/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110609/2f9fe237/attachment.htm 


More information about the KDE-Telepathy mailing list