Review Request: Fix query to populate a Person with Contacts

[Daniele Elmo Domenichelli]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101546/#review3780
-----------------------------------------------------------

Ship it!


Looks fine to me... I'm glad that we have an "nco:isAccessedBy" property now!

- Daniele Elmo


On June 8, 2011, 4:03 p.m., George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101546/
> -----------------------------------------------------------
> 
> (Updated June 8, 2011, 4:03 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Fix the query that populates a Person with their Contacts to actually work with current ontologies.
> 
> 
> Diffs
> -----
> 
>   src/core/person.cpp 813b41fa1541214fd9617127dac7f6ca1226676c 
> 
> Diff: http://git.reviewboard.kde.org/r/101546/diff
> 
> 
> Testing
> -------
> 
> Manually verified this now works. Unfortunately, there is no unit test coverage for this functionality yet, but it's going to be a big operation to set up, so it'll have to come in a separate patch.
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110608/6c6ea582/attachment.htm