Review Request: Port the PersonSetModel to tpqt4 >=0.5
Daniele Elmo Domenichelli
daniele.domenichelli at gmail.com
Wed Jun 8 18:30:14 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101545/#review3778
-----------------------------------------------------------
Are ui/person-set-model.{cpp,h} files just building without any modification?
- Daniele Elmo
On June 8, 2011, 3:23 p.m., George Goldberg wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101545/
> -----------------------------------------------------------
>
> (Updated June 8, 2011, 3:23 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> This patch reinstates the PersonSetModel - the main part of the telepathy-kde UI components that is useful to the ContactList. It is a trivial port to tpqt4 >= 0.5 and also reinstates the unit test for this class and makes it work with current telepathy-testlib.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 54478d18c86d2aea915a1abe24cd4c4cfd2d3ca7
> tests/CMakeLists.txt da55c6372faac35ce72a9780fb2c0977bdd2a84e
> tests/person-set-model-test.h debbcac9d50351175afba339417eec2e426bacc3
> tests/person-set-model-test.cpp 9da86360a8cdcea7d37b884f3c1bf0d6f9ff5939
>
> Diff: http://git.reviewboard.kde.org/r/101545/diff
>
>
> Testing
> -------
>
> Unit tests all pass.
>
>
> Thanks,
>
> George
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110608/38ba7a48/attachment-0001.htm
More information about the KDE-Telepathy
mailing list