Review Request: Make sure contact info is up to date in Nepomuk immediately after launching the tp-nepomuk-service

Dario Freddi drf at kde.org
Wed Jun 8 17:07:52 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101544/#review3773
-----------------------------------------------------------

Ship it!


Looks good

- Dario


On June 8, 2011, 3:04 p.m., George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101544/
> -----------------------------------------------------------
> 
> (Updated June 8, 2011, 3:04 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Ensure that the Nepomuk DB contains correct information for all properties of contacts after launching the tp-nepomuk-service
> 
> The tpqt4 version bump is because for this to work correctly, we must have a tpqt4 with fully working contact factories.
> 
> 
> Diffs
> -----
> 
>   cmake/modules/FindTelepathyQt4.cmake f949c8c8004f6894da94dd9286732d8ccdf827f2 
>   contact.cpp 4a1c5c61a06446f8fde80df71a396022b658e545 
> 
> Diff: http://git.reviewboard.kde.org/r/101544/diff
> 
> 
> Testing
> -------
> 
> Tests still pass, and anecdotal testing shows that the problem seems to be fixed.
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110608/04e7d53f/attachment.htm 


More information about the KDE-Telepathy mailing list