Review Request: fix usage of deprecated tpqt4 signals

Daniele Elmo Domenichelli daniele.domenichelli at gmail.com
Wed Jun 8 15:14:20 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101541/#review3765
-----------------------------------------------------------

Ship it!


Just one comment...


contact.cpp
<http://git.reviewboard.kde.org/r/101541/#comment3095>

    Probably also the Contact::onPublishStateChanged and the Contact::publishStateChanged should be modified to reflect this change and emit the message as well


- Daniele Elmo


On June 8, 2011, 12:23 p.m., George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101541/
> -----------------------------------------------------------
> 
> (Updated June 8, 2011, 12:23 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Fix usage of deprecated tpqt4 signals.
> 
> 
> Diffs
> -----
> 
>   contact.cpp 4a1c5c61a06446f8fde80df71a396022b658e545 
> 
> Diff: http://git.reviewboard.kde.org/r/101541/diff
> 
> 
> Testing
> -------
> 
> unit tests still pass
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110608/f17c0092/attachment.htm 


More information about the KDE-Telepathy mailing list