Review Request: merge branch "nwoki-qml-redesign" into master

David Edmundson kde at davidedmundson.co.uk
Wed Jun 8 12:49:13 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101539/#review3763
-----------------------------------------------------------

Ship it!


Read through the code from your git branch. All looks pretty standard. 

+1 from me, but try and get someone else to check before merging (as it's a big set of changes)

- David


On June 8, 2011, 8:19 a.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101539/
> -----------------------------------------------------------
> 
> (Updated June 8, 2011, 8:19 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> May I have the permission to merge my branch into the master branch of "telepathy-presence-applet" ? Attached are two screens of how the presence plasmoid looks like.
> This way people can start using it and report bugs (some devs didn't know this existed)
> 
> 
> Diffs
> -----
> 
> 
> Diff: http://git.reviewboard.kde.org/r/101539/diff
> 
> 
> Testing
> -------
> 
> See screenshots
> 
> 
> Screenshots
> -----------
> 
> Dark prev
>   http://git.reviewboard.kde.org/r/101539/s/177/
> air prev
>   http://git.reviewboard.kde.org/r/101539/s/178/
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110608/f2808d63/attachment.htm 


More information about the KDE-Telepathy mailing list