Review Request: Set correct protocol icon for accounts in dataengine

[Olli Salli]

> On June 7, 2011, 11:57 a.m., David Edmundson wrote:
> > presencesource.cpp, line 90
> > <http://git.reviewboard.kde.org/r/101531/diff/1/?file=24027#file24027line90>
> >
> >     sure you don't want m_account->profile()->iconName()
> 
> Francesco Nwokeka wrote:
>     Aren't they the same thing?
> 
> Olli Salli wrote:
>     The account icon name uses in decreasing order of preference 1) any custom icon an user has set for the account, from kde-telepathy (which afaik doesn't support it) or otherwise (other telepathy clients) 2) the profile icon, if enabled and found 3) the protocol info icon, if enabled and found 4) im-<protocolname>
>     
>     Profile::iconName() is just 2 of these, with no fallbacks to the others nor a provision to use an icon explicitly set by an user for the account.
> 
> Francesco Nwokeka wrote:
>     Are you suggesting me to use the first or the one suggested by david?

As discussed in IRC, I'd use Account::iconName() as it considers everything, including the profile icon if available.


- Olli


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101531/#review3738
-----------------------------------------------------------


On June 7, 2011, 9:11 a.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101531/
> -----------------------------------------------------------
> 
> (Updated June 7, 2011, 9:11 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch sets the correct protocol icon for accounts.
> The protocol icon has been connected to a slot that updates the icon name in case the user changes it (suggested by oggis)
> 
> 
> Diffs
> -----
> 
>   presencesource.h 9706746 
>   presencesource.cpp e6f9ca3 
> 
> Diff: http://git.reviewboard.kde.org/r/101531/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110607/91e39b58/attachment.htm