Review Request: Set correct protocol icon for accounts in dataengine
David Edmundson
kde at davidedmundson.co.uk
Tue Jun 7 13:57:39 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101531/#review3738
-----------------------------------------------------------
When can a user change the account icon?
Code is fine, I just don't understand where you need it.
presencesource.cpp
<http://git.reviewboard.kde.org/r/101531/#comment3089>
sure you don't want m_account->profile()->iconName()
- David
On June 7, 2011, 9:11 a.m., Francesco Nwokeka wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101531/
> -----------------------------------------------------------
>
> (Updated June 7, 2011, 9:11 a.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> This patch sets the correct protocol icon for accounts.
> The protocol icon has been connected to a slot that updates the icon name in case the user changes it (suggested by oggis)
>
>
> Diffs
> -----
>
> presencesource.h 9706746
> presencesource.cpp e6f9ca3
>
> Diff: http://git.reviewboard.kde.org/r/101531/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Francesco
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110607/99751a60/attachment.htm
More information about the KDE-Telepathy
mailing list