Review Request: Show the offline icon when the connection closes

David Edmundson kde at davidedmundson.co.uk
Mon Jun 6 13:11:16 CEST 2011



> On June 6, 2011, 11:09 a.m., David Edmundson wrote:
> >

Also IIRC there is a bug report on this, could you close it with the commit.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101518/#review3716
-----------------------------------------------------------


On June 6, 2011, 8:30 a.m., George Kiagiadakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101518/
> -----------------------------------------------------------
> 
> (Updated June 6, 2011, 8:30 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Summary
> -------
> 
> commit 2f43d08a1aa275fe3d28fe5d0ca2d9fcfc339a09
> Author: George Kiagiadakis <george.kiagiadakis at collabora.com>
> Date:   Mon Jun 6 11:18:57 2011 +0300
> 
>     Remove unused icon variable.
> 
> commit ed95fed5432d471aa0afef757fd1bffe9ad85427
> Author: George Kiagiadakis <george.kiagiadakis at collabora.com>
> Date:   Mon Jun 6 11:18:29 2011 +0300
> 
>     Show the offline icon when the connection closes.
> 
> 
> Diffs
> -----
> 
>   lib/chat-widget.cpp 99edcc10a49575f2145a340ac3d2fdceb2e175a1 
> 
> Diff: http://git.reviewboard.kde.org/r/101518/diff
> 
> 
> Testing
> -------
> 
> Tested by starting a chat, then disconnecting the account, then connecting it again.
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110606/dea76c3f/attachment.htm 


More information about the KDE-Telepathy mailing list