Review Request: Set the default size of the window to be something sensible

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101519/#review3717
-----------------------------------------------------------

Ship it!


Could you confirm that with the patch on the second time of loading it opens with it's last saved size. If so +1 from me.

- David


On June 6, 2011, 8:49 a.m., George Kiagiadakis wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101519/
> -----------------------------------------------------------
> 
> (Updated June 6, 2011, 8:49 a.m.)
> 
> 
> Review request for Telepathy and David Edmundson.
> 
> 
> Summary
> -------
> 
> This sets the default size of the text ui window to be 460x440 (a value that looked good to me). Previously the default size was unset, which caused a really tiny window to show up the first time that you opened it. Of course the size is later saved in the config file (KMainWindow magic), so only new users notice the bug.
> 
> 
> Diffs
> -----
> 
>   app/chat-window.cpp 00c6bf9528c535130815fed0a02b91c2cc99b09b 
> 
> Diff: http://git.reviewboard.kde.org/r/101519/diff
> 
> 
> Testing
> -------
> 
> Removed the config file, started a chat. The window starts at 460x440 as expected.
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110606/5642b3d5/attachment.htm