Review Request: Add a lineedit to change the "Resource" on gabble accounts.

[George Kiagiadakis]

> On May 12, 2011, 12:41 p.m., Daniele Elmo Domenichelli wrote:
> > IIRC the resource parameter should be handled together with the priority parameter (that is missing as well) like kopete does. (Also kopete has an useful feature "when absent, adjust priority to", but I believe that it is not a xmpp feature, but something implemented by kopete checking the user's activity.)
> > Messages are sent by the xmpp server to the resource with the higher priority and I also believe that's the only use for the resource parameter. (I just found [1], so I may be right)
> > 
> > Therefore I'm not sure if it makes sense to allow to set just the resource parameter alone.
> > 
> > [1]http://wiki.xmpp.org/web/Jabber_Resources

I've never heard of the priority and what I have seen in practice is that when I am logged in from several clients on xmpp, messages appear in all of them (for example on the desktop and the N900). However, I've also seen two different setups of telepathy not being able to connect to the same xmpp account because they had both their resource unset, in which case I had to start empathy in one of them and set the resource from there before I could continue. So, I think that having a lineedit to change the resource name is required, even if it may not be the best solution.

PS: The N900 also has a Resource lineedit in the advanced options (by default set to "Maemo") and it has no priority adjustment option.

PS 2: Ship it!


- George


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101319/#review3278
-----------------------------------------------------------


On May 9, 2011, 3:28 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101319/
> -----------------------------------------------------------
> 
> (Updated May 9, 2011, 3:28 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Add a lineedit to change the "Resource" on gabble accounts.
> 
> 
> Diffs
> -----
> 
>   gabble/server-settings-widget.cpp 7bb9ee06faa76c78e976b47172443125569acb8e 
>   gabble/server-settings-widget.ui 711355301f18f32a0f185cfd63cea8670292242d 
> 
> Diff: http://git.reviewboard.kde.org/r/101319/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110606/5fae9569/attachment.htm