Review Request: Make some improvements to Contact class ready for implementing Contactable interface

George Goldberg grundleborg at googlemail.com
Sun Jul 31 16:00:27 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102158/
-----------------------------------------------------------

Review request for Telepathy and Dario Freddi.


Summary
-------

Make some improvements to Contact class ready for implementing Contactable interface.
- Make the IM ID be a property (also useful for the ContactList UI)
- Make the Contact keep a copy of the local account through which it's accessed, and make this accessible to Contactable and it's soon-to-be subclasses.

The actuall implementation of the contactable interface will be in a later patch.


Diffs
-----

  src/core/contact.h 64bc4de4508f3ccce97e248b979bbc30f23452e2 
  src/core/contact.cpp 246f2afad0ac377aba9e4b94fac5d5d7faa148bf 
  src/core/person.cpp ee5650e23dbe281c5f6661fb2becfc659cd3c7ab 

Diff: http://git.reviewboard.kde.org/r/102158/diff


Testing
-------


Thanks,

George

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110731/d71dfba7/attachment.htm 


More information about the KDE-Telepathy mailing list