Review Request: kcall ui crashes on hangup

George Kiagiadakis kiagiadakis.george at gmail.com
Sat Jul 30 19:19:09 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102151/#review5238
-----------------------------------------------------------


That widget should be there, so the patch is not entirely correct... But in any case, this code will be rewritten, so for the moment you can commit it if it makes you happy :)

- George


On July 30, 2011, 4:42 p.m., Jeremy Paul Whiting wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102151/
> -----------------------------------------------------------
> 
> (Updated July 30, 2011, 4:42 p.m.)
> 
> 
> Review request for Telepathy and George Kiagiadakis.
> 
> 
> Summary
> -------
> 
> When hanging up by either the hangup toolbar button or the menu action. I get a crash here calling videoWidget->hide() while videoWidget is null.
> 
> 
> Diffs
> -----
> 
>   src/callwindow.cpp deab64a 
> 
> Diff: http://git.reviewboard.kde.org/r/102151/diff
> 
> 
> Testing
> -------
> 
> This patch fixes the issue here.
> 
> 
> Thanks,
> 
> Jeremy Paul
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110730/100270eb/attachment.htm 


More information about the KDE-Telepathy mailing list