Review Request: Fix crash caused by nested event-loops

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102139/#review5221
-----------------------------------------------------------

Ship it!


Looks good - of course in the long-term it would be great to use async queries.

- Dario


On July 29, 2011, 2:20 p.m., George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102139/
> -----------------------------------------------------------
> 
> (Updated July 29, 2011, 2:20 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This is not a full asyncification of the nepomuk service just yet - I'm doing it a bit at a time. However, the changes in this patch improve performance by only doing the query for accounts and contacts once, rather than each time and account and contact is constructed. They also improve performance by only writing changes to Nepomuk when the before is actually different to the after.
> 
> Coincidentally, this also fixes the problem where telepathy objects can process events when the Nepomuk query service nested event loop runs.
> 
> 
> Diffs
> -----
> 
>   nepomuk-storage.cpp 92780648c1624e72c8575b936de57e5447e1d793 
>   tests/storage-test.cpp ed3d35c3c8720e6b01056f0407bc682c52eee6fd 
> 
> Diff: http://git.reviewboard.kde.org/r/102139/diff
> 
> 
> Testing
> -------
> 
> Unit tests still pass (with appropriate modification).
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110729/e75def6e/attachment.htm