Review Request: Implement a cache pixmap for avatars

[Dario Freddi]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102050/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

At the moment, each time an avatar is requested, a new pixmap from the image file is created. This is of course more than evil, and this patch aims to fix that. PixmapCache is a proxy to QPixmapCache for handling avatars' pixmaps efficiently. If this patch gets in, from now on every avatar consumer (tooltips, list view, etc) should get his avatar pixmaps through the cache. Of course, in the future, this will be extended to support the most common and most unefficiently handled pixmaps in our code.


Diffs
-----

  CMakeLists.txt de2827f 
  contact-delegate-compact.cpp 45cd282 
  contact-delegate.cpp 159894f 
  pixmap-cache.h PRE-CREATION 
  pixmap-cache.cpp PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/102050/diff


Testing
-------

Apparently everything still works


Thanks,

Dario

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110722/af01840e/attachment.htm