Review Request: Add a title to the account presence menu
George Kiagiadakis
kiagiadakis.george at gmail.com
Fri Jul 22 11:24:02 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102023/#review4959
-----------------------------------------------------------
account-button.cpp
<http://git.reviewboard.kde.org/r/102023/#comment4349>
This object is leaked. Why not create it on the stack instead?
- George
On July 20, 2011, 8:04 p.m., Maxime Corteel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102023/
> -----------------------------------------------------------
>
> (Updated July 20, 2011, 8:04 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> Added a title to the account presence menu showing the account displayName
>
>
> Diffs
> -----
>
> account-button.cpp 5c9e135
>
> Diff: http://git.reviewboard.kde.org/r/102023/diff
>
>
> Testing
> -------
>
> Changed status
>
>
> Screenshots
> -----------
>
> Menu with title
> http://git.reviewboard.kde.org/r/102023/s/208/
> With elision
> http://git.reviewboard.kde.org/r/102023/s/209/
>
>
> Thanks,
>
> Maxime
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110722/3af2536e/attachment.htm
More information about the KDE-Telepathy
mailing list