Review Request: Add a title to the account presence menu

Maxime Corteel mcorteel at gmail.com
Wed Jul 20 20:26:14 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102023/
-----------------------------------------------------------

(Updated July 20, 2011, 6:26 p.m.)


Review request for Telepathy.


Changes
-------

Even better (I know, like it's possible...)! Now with the elided text for long account names (which is all of them). I elided the text on the right because eliding it in the middle made accounts like imamazing at gmail.com and imamazing at hotmail.com look the same (imazin...ail.com).


Summary
-------

Added a title to the account presence menu showing the account displayName


Diffs (updated)
-----

  account-button.cpp 5c9e135 

Diff: http://git.reviewboard.kde.org/r/102023/diff


Testing
-------

Changed status


Screenshots
-----------

Menu with title
  http://git.reviewboard.kde.org/r/102023/s/208/
With elision
  http://git.reviewboard.kde.org/r/102023/s/209/


Thanks,

Maxime

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110720/f32de170/attachment.htm 


More information about the KDE-Telepathy mailing list