Review Request: KIcon's no longer pointers

[George Kiagiadakis]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102022/#review4904
-----------------------------------------------------------

Ship it!


Looks fine.
Now that I read it againThe old code looks quite dangerous. I think it would crash in some cases.
Thanks for fixing.

- George


On July 20, 2011, 4:41 p.m., George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102022/
> -----------------------------------------------------------
> 
> (Updated July 20, 2011, 4:41 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> as summary
> 
> 
> Diffs
> -----
> 
>   src/core/contact.cpp 85cc78ebef9d4f338634319de04aa60153f3c8b9 
>   src/core/person.cpp 4a4f69f3f11238e83d95614c662b9f2c34441d7a 
> 
> Diff: http://git.reviewboard.kde.org/r/102022/diff
> 
> 
> Testing
> -------
> 
> unit tests pass
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110720/8694aef8/attachment.htm