Review Request: Remove the deprecated code from telepathy-kde to avoid confusion

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102021/#review4894
-----------------------------------------------------------

Ship it!


If you're sure they're not useful to anyone. Ship it! It certainly has been causing some confusion.

ModelMenu looks like a useful class on it's own - almost worthy of being in KDELibs, I'm going to save that.

- David


On July 20, 2011, 2:25 p.m., George Goldberg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102021/
> -----------------------------------------------------------
> 
> (Updated July 20, 2011, 2:25 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> There seems to be a lot of confusion about what code is meant to be used in telepathy-kde and what is deprecated stuff just hanging around in case it is useful. So, this patch removes everything deprecated. We can always reinstate it from the history at a later date if for some reason we want to resurrect one of these classes, but for now it makes it a hell of a lot more obvious which classes to use for stuff.
> 
> 
> Diffs
> -----
> 
>   src/CMakeLists.txt f6a24df3274839ac8a42e94a381998a57ff4180c 
>   src/KTelepathy/AbstractTreeItem b1dee65b37b4b2c4c71a92ff2360750cdc1860fd 
>   src/KTelepathy/AccountItem 52c328397b26046ee5c281444188ac4a852abdcd 
>   src/KTelepathy/AccountsModel 823d5599396f0d505ebf2895596351fd45e7e4eb 
>   src/KTelepathy/ContactItem f31000ed74d9d78deed476441039f3145fcf0115 
>   src/KTelepathy/ContactsListModel 243371c955b0256f3ad80d74f20f9ad6e32818c4 
>   src/KTelepathy/ContactsModelMenu aa09334c7a1a78f0d75d518d8281172bfbb00ea4 
>   src/KTelepathy/GroupedContactsProxyModel 2b7a7cfee951f5455decfa05485fee7c7a47661e 
>   src/KTelepathy/MetaContactItem f4cdebd395baf6b95692e13a7db3b6e5697b2dad 
>   src/KTelepathy/ModelMenu 419c8d847ee19b2359693941309513fa7dd5f0e9 
>   src/ui/abstract-tree-item.h dc73e5736ab1ec0bfc1895c6d0ce70943df94bc7 
>   src/ui/abstract-tree-item.cpp 30a9b8b67e5cf1b024aa0dd80f59a0d1ff38bd2d 
>   src/ui/account-item.h bfab4d51cad503472e944e0426eb7f1b9a54a7c2 
>   src/ui/account-item.cpp 04f6431779bf50d1c6f722490a6eaa9a4625c8e1 
>   src/ui/accounts-model.h a2c3f9df67c56d91b2a61c0eec2ed072dde8bff1 
>   src/ui/accounts-model.cpp 2c095c6b06e69d53c0e1d1b817a9e6faa6040606 
>   src/ui/contact-item.h 37ae163b773adfb48063d04a1a518f7cc196eaeb 
>   src/ui/contact-item.cpp 9906245a1c515ad266e33ff425d81deea5358607 
>   src/ui/contacts-list-model.h 4311d0e0b79198adde16d7a967705c04f533f728 
>   src/ui/contacts-list-model.cpp c066d7f21fcfeda0193c3d15afc785cc788f1953 
>   src/ui/contacts-modelmenu.h fcff12be32cf3d652484ab7700250ff5476a1208 
>   src/ui/contacts-modelmenu.cpp 4bb2b3e356185b0e3106aee7c09bb647898cbc15 
>   src/ui/grouped-contacts-proxy-model.h 19530934b98c16d6036b51430e47b2aeb7afd654 
>   src/ui/grouped-contacts-proxy-model.cpp 482847b81323ec6053b2b4a973957828ff330e96 
>   src/ui/meta-contact-item.h 2feb9a63edc3a606260ba4a79809a1b8d6de0b74 
>   src/ui/meta-contact-item.cpp 1a5bdd38427fb2ac326dcbd019d1fb89d6e014d6 
>   src/ui/modelmenu.h a8b2dfc38f3ba665bc7fc4aea89a10157fb9f7ba 
>   src/ui/modelmenu.cpp 1b69e1e9099ecc3c5c71342ce09421d413319d90 
> 
> Diff: http://git.reviewboard.kde.org/r/102021/diff
> 
> 
> Testing
> -------
> 
> Everything still compiles.
> 
> 
> Thanks,
> 
> George
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110720/1e87fbf6/attachment.htm