Review Request: Use Tp::ConnectionPresenceType instead of uint in Person and Contact classes for the presenceType property.

[George Goldberg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101636/
-----------------------------------------------------------

(Updated July 20, 2011, 2:04 p.m.)


Review request for Telepathy.


Changes
-------

Changed presence type to use Tp::ConnectionPresenceType instead of uint as suggested by David.


Summary (updated)
-------

Use Tp::ConnectionPresenceType instead of uint in Person and Contact classes for the presenceType property.


Major work on Contact, Person and PersonSetModel to make all the half implemented bits work properly and as intended.

This means the three classes should now be fully working with all the basic read-only properties, including presence, caps, avatar, groups, displayname, presence message.

Add presenceType as a piece of info that can be got from the model.


Name the Role enum and make it a QMetaType.


Add support for a ItemTypeRole to the model, which indicates what type the Item is, e.g. Person, Contact or Group etc. The idea is that subclasses or proxy models will extend this.


Diffs (updated)
-----

  src/core/contact.h 026a7361a35556a261a1ad10910bf846b024bd64 
  src/core/contact.cpp c91058a261fe4f79dd505d97f901401c09ba53b4 
  src/core/person.h eb017da98d8a01a8555ef3568f095bf2cfe74109 
  src/core/person.cpp 4269789b0d45838024901907d728b058ae17e8de 
  src/ui/person-set-model.h 95416fff218ad568149ad453f692a9fcdfa635b2 
  src/ui/person-set-model.cpp 7a5849af208d7596171ebb8c95adcf488135d73d 

Diff: http://git.reviewboard.kde.org/r/101636/diff


Testing
-------

Unit tests still pass.


Thanks,

George

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110720/52b4e5e5/attachment-0001.htm