Review Request: Only show "do you want to disconnect dialog" when manually closing the window, not on computer shutdown.

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102014/#review4885
-----------------------------------------------------------

Ship it!


Nice patch! Few nitpicks below..


contact-list-application.h
<http://git.reviewboard.kde.org/r/102014/#comment4261>

    Add licence info ;)



contact-list-application.h
<http://git.reviewboard.kde.org/r/102014/#comment4260>

    I think you might remove these



contact-list-application.cpp
<http://git.reviewboard.kde.org/r/102014/#comment4262>

    Licence here as well



main-widget.cpp
<http://git.reviewboard.kde.org/r/102014/#comment4263>

    Useless newline here



main-widget.cpp
<http://git.reviewboard.kde.org/r/102014/#comment4264>

    ...and useless space in the if --> if (!app...)


- Martin


On July 19, 2011, 11:32 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102014/
> -----------------------------------------------------------
> 
> (Updated July 19, 2011, 11:32 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Only show "do you want to disconnect dialog" when manually closing the window, not on computer shutdown.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a94fcdaac788e9b5d0c068963112170d83f4f8f4 
>   contact-list-application.h PRE-CREATION 
>   contact-list-application.cpp PRE-CREATION 
>   main-widget.cpp 20995f6fd3f038ed3f5046f1ee0cb0a63c1c251c 
>   main.cpp 1b92c79ef200abb6bc71cdf18985a1b17f184617 
> 
> Diff: http://git.reviewboard.kde.org/r/102014/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110720/dec59557/attachment-0001.htm