Review Request: Connect account when it is enabled by ticking the checkbox in the KCM

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101980/#review4859
-----------------------------------------------------------


This review has been submitted with commit 41e61953e854bfb3d789f52390976d69f885483e by Paolo Capriotti to branch master.

- Commit


On July 17, 2011, 6 p.m., Paolo Capriotti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101980/
> -----------------------------------------------------------
> 
> (Updated July 17, 2011, 6 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> As discussed on IRC:
> 
> [18:13] <pcapriotti> the only question left, then, is whether we want the account to go online when we disable and reenable
> [18:13] <d_ed> I'm fine with it.
> [18:13] <d_ed> I think it's a good idea, the user has made a concious action, they can't be surprised when it reconnects.
> 
> 
> Diffs
> -----
> 
>   src/kcm-telepathy-accounts.cpp 26e5f0b 
> 
> Diff: http://git.reviewboard.kde.org/r/101980/diff
> 
> 
> Testing
> -------
> 
> open KCM, disable, reenable -> account online
> 
> 
> Thanks,
> 
> Paolo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110719/87d0ca92/attachment.htm