Review Request: Connect account when it is enabled by ticking the checkbox in the KCM

[Martin Klapetek]

> On July 17, 2011, 8:25 p.m., Martin Klapetek wrote:
> > I know this discussion was held before, but I don't really agree with this. What if the user wants to connect it later (and since there is no other way how to enable them than from KCM, he has to do it this way)? We should always provide a method for bringing the account online/offline manually if we want to do automagic.
> 
> David Edmundson wrote:
>     Under what circumstance would you want to enable it without going online?
>     
>     It works for Empathy. If it causes issues we can always change it later.

For example this scenairo - you are in systemsettings (for some other setting), you remember that you wanted to enable some IM accounts and you may as well do it while you have the systemsettings opened, but you don't want to connect yet (for the reasons already discussed). It is really the same'ol' discussion all over again. I think a small checkbox in otherwise unused space won't hurt anyone and may help some. 

My 2 cents..


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101980/#review4784
-----------------------------------------------------------


On July 17, 2011, 6 p.m., Paolo Capriotti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101980/
> -----------------------------------------------------------
> 
> (Updated July 17, 2011, 6 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> As discussed on IRC:
> 
> [18:13] <pcapriotti> the only question left, then, is whether we want the account to go online when we disable and reenable
> [18:13] <d_ed> I'm fine with it.
> [18:13] <d_ed> I think it's a good idea, the user has made a concious action, they can't be surprised when it reconnects.
> 
> 
> Diffs
> -----
> 
>   src/kcm-telepathy-accounts.cpp 26e5f0b 
> 
> Diff: http://git.reviewboard.kde.org/r/101980/diff
> 
> 
> Testing
> -------
> 
> open KCM, disable, reenable -> account online
> 
> 
> Thanks,
> 
> Paolo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110719/f290ec1d/attachment.htm