Review Request: Contact Info Dialog

[David Edmundson]

> On July 17, 2011, 10:58 p.m., Francesco Nwokeka wrote:
> > Screenshot: 
> > <http://git.reviewboard.kde.org>
> >
> >     we could get these aligned in another patch
> 
> Martin Klapetek wrote:
>     Definitely needs alignment. Also, can we hide the description in a tooltip (perhaps over an question mark icon)?

Done as tooltips, though I'm trying to avoid people looking at it and saying "wtf is a publish state", I'm not sure tooltips are as obvious as I'd like. Maybe we can go for the question mark thing.


> On July 17, 2011, 10:58 p.m., Francesco Nwokeka wrote:
> > dialogs/contact-info.cpp, line 11
> > <http://git.reviewboard.kde.org/r/101989/diff/1/?file=27326#file27326line11>
> >
> >     const reference the "Tp::ContactPtr" ? you only use it to read info.

Done.

Though it may revert back to this in future if we add any actions in here.


> On July 17, 2011, 10:58 p.m., Francesco Nwokeka wrote:
> > dialogs/contact-info.cpp, line 33
> > <http://git.reviewboard.kde.org/r/101989/diff/1/?file=27326#file27326line33>
> >
> >     A more elaborate regex is in AdiumView. You could steal that one or merge the two together to obtain a better link parser

no there's not. I stole this from AdiumView :-)
(it's the newer version that works with all protocols)


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101989/#review4795
-----------------------------------------------------------


On July 18, 2011, 1:12 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101989/
> -----------------------------------------------------------
> 
> (Updated July 18, 2011, 1:12 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Contact info dialog, shows information about a user. Accessible via a context menu.
> I'm aware it's not the prettiest dialog in the world, but it's better to get something merged which everyone can fix than to have it stuck here doing nothing.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a94fcdaac788e9b5d0c068963112170d83f4f8f4 
>   dialogs/contact-info.h PRE-CREATION 
>   dialogs/contact-info.cpp PRE-CREATION 
>   dialogs/contact-info.ui PRE-CREATION 
>   main-widget.h 6fd3e8bb0a3999b284a97d5ff6f7f832884411b7 
>   main-widget.cpp 20995f6fd3f038ed3f5046f1ee0cb0a63c1c251c 
> 
> Diff: http://git.reviewboard.kde.org/r/101989/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/101989/s/206/
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110718/a5c3bc7a/attachment-0001.htm