Review Request: Refactor presence handling in AccountButton.

Paolo Capriotti p.capriotti at gmail.com
Mon Jul 18 02:17:49 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101992/
-----------------------------------------------------------

(Updated July 18, 2011, 12:17 a.m.)


Review request for Telepathy.


Summary
-------

* Factored out a function to get the correct action corresponding to the
  current presence.
* Use status first for matching, then type if status fails.
* Use 'away' icon for the BRB action.
* Remove unused code.


Diffs
-----

  account-button.h fb98a0d0de34565fb0c92ccd76b737be970ba134 
  account-button.cpp 7763858d2705e9afb61a196f392eafebc63b09c7 

Diff: http://git.reviewboard.kde.org/r/101992/diff


Testing (updated)
-------

tested with gabble


Thanks,

Paolo

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110718/4a412a4c/attachment.htm 


More information about the KDE-Telepathy mailing list