Review Request: Contact Info Dialog

[Francesco Nwokeka]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101989/#review4795
-----------------------------------------------------------



Screenshot: 
<http://git.reviewboard.kde.org//r/101989/#scomment11>
    this handsome lad is not included in the patch.. sorry ladies ;)


Screenshot: 
<http://git.reviewboard.kde.org//r/101989/#scomment12>
    we could get these aligned in another patch


Screenshot: 
<http://git.reviewboard.kde.org//r/101989/#scomment13>
    maybe make this info bold?


dialogs/contact-info.cpp
<http://git.reviewboard.kde.org/r/101989/#comment4167>

    const reference the "Tp::ContactPtr" ? you only use it to read info.



dialogs/contact-info.cpp
<http://git.reviewboard.kde.org/r/101989/#comment4168>

    A more elaborate regex is in AdiumView. You could steal that one or merge the two together to obtain a better link parser



dialogs/contact-info.cpp
<http://git.reviewboard.kde.org/r/101989/#comment4169>

    move this up one line



dialogs/contact-info.cpp
<http://git.reviewboard.kde.org/r/101989/#comment4170>

    move up one line



dialogs/contact-info.cpp
<http://git.reviewboard.kde.org/r/101989/#comment4171>

    see previous



dialogs/contact-info.cpp
<http://git.reviewboard.kde.org/r/101989/#comment4172>

    see previous



dialogs/contact-info.cpp
<http://git.reviewboard.kde.org/r/101989/#comment4173>

    see previous



dialogs/contact-info.cpp
<http://git.reviewboard.kde.org/r/101989/#comment4174>

    see previous



main-widget.cpp
<http://git.reviewboard.kde.org/r/101989/#comment4166>

    use "help-about" icon?


- Francesco


On July 17, 2011, 10:36 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101989/
> -----------------------------------------------------------
> 
> (Updated July 17, 2011, 10:36 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Contact info dialog, shows information about a user. Accessible via a context menu.
> I'm aware it's not the prettiest dialog in the world, but it's better to get something merged which everyone can fix than to have it stuck here doing nothing.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a94fcdaac788e9b5d0c068963112170d83f4f8f4 
>   dialogs/contact-info.h PRE-CREATION 
>   dialogs/contact-info.cpp PRE-CREATION 
>   dialogs/contact-info.ui PRE-CREATION 
>   main-widget.h 6fd3e8bb0a3999b284a97d5ff6f7f832884411b7 
>   main-widget.cpp 20995f6fd3f038ed3f5046f1ee0cb0a63c1c251c 
> 
> Diff: http://git.reviewboard.kde.org/r/101989/diff
> 
> 
> Testing
> -------
> 
> 
> Screenshots
> -----------
> 
> 
>   http://git.reviewboard.kde.org/r/101989/s/205/
> 
> 
> Thanks,
> 
> David
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110717/4431fe17/attachment-0001.htm