Review Request: Use type instead of status to identify the current presence.

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101984/#review4790
-----------------------------------------------------------


I can see why you did it, however I'm not sure it's overall right.

Telepathy presence is very confusing, here's a bad attempt at an explanation:

 - there are lots of status's defined by "status", this is a string identifier. It will be values such as "away" "dnd", "online". 

 - because we're dealing with strings telepathy provides a fallback solution as a smaller fixed set of statuses as a simple enum. This is to be used if you don't understand the status.

All presence stuff /should/ (but probably don't) be switching on the string (status), then falling back to using the enum value (type)

- David


On July 17, 2011, 7:43 p.m., Paolo Capriotti wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101984/
> -----------------------------------------------------------
> 
> (Updated July 17, 2011, 7:43 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> The presence status does not uniquely identify the current presence, so use type instead.
> 
> 
> Diffs
> -----
> 
>   account-button.cpp 2ccda54 
> 
> Diff: http://git.reviewboard.kde.org/r/101984/diff
> 
> 
> Testing
> -------
> 
> Change presence in contact list, observe that the presence button's tooltip matches the action text for all actions.
> 
> 
> Thanks,
> 
> Paolo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110717/2b86c87d/attachment.htm