Review Request: unified notifyrc file

David Edmundson kde at davidedmundson.co.uk
Thu Jul 14 00:13:03 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101948/#review4716
-----------------------------------------------------------

Ship it!


This isn't perfect: There's two called "Incoming Message" (presumably once from the Text UI, one from approver)

However lets ship this, update all the code, and deal with that in a future pair of patches

- David


On July 13, 2011, 10:05 p.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101948/
> -----------------------------------------------------------
> 
> (Updated July 13, 2011, 10:05 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> Made a unique notifyrc file called "ktelepathy" for all components to use. For now it's in the contactlist, a component everyone will need in the pre-alpha-omega-beta-jedi padawan release. 
> In the future this will be moved to a centralized component
> 
> 
> This addresses bug 275718.
>     http://bugs.kde.org/show_bug.cgi?id=275718
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 809dc0d 
>   ktelepathy.notifyrc PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/101948/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110713/b6b8250f/attachment-0001.htm 


More information about the KDE-Telepathy mailing list