Review Request: DBus check for plasmoid (aka "Do you want to go offline?" dialog)

Commit Hook null at kde.org
Wed Jul 13 17:51:09 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101918/#review4693
-----------------------------------------------------------


This review has been submitted with commit d175fb4c746cfe564b515fb37bf0c0637183e9f8 by Martin Klapetek to branch master.

- Commit


On July 13, 2011, 3:08 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101918/
> -----------------------------------------------------------
> 
> (Updated July 13, 2011, 3:08 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This is the second part of the DBus-plasmoid-check patch. It checks if the interface exists on dbus and is valid. If not, it displays a dialog asking user what to do (see screenshot). It can also remember the preference. Please also check spelling/grammar of the text.
> 
> 
> Diffs
> -----
> 
>   main-widget.h 313f74f 
>   main-widget.cpp 28c2d9a 
> 
> Diff: http://git.reviewboard.kde.org/r/101918/diff
> 
> 
> Testing
> -------
> 
> Tested both with plasmoid active and not active, works as expected.
> 
> 
> Screenshots
> -----------
> 
> The quit dialog
>   http://git.reviewboard.kde.org/r/101918/s/194/
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110713/ae66d51c/attachment.htm 


More information about the KDE-Telepathy mailing list