Review Request: DBus check for plasmoid (aka "Do you want to go offline?" dialog)

Martin Klapetek martin.klapetek at gmail.com
Wed Jul 13 17:08:23 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101918/
-----------------------------------------------------------

(Updated July 13, 2011, 3:08 p.m.)


Review request for Telepathy.


Changes
-------

Suggested changes plus changed the other foreachs to use refs.


Summary
-------

This is the second part of the DBus-plasmoid-check patch. It checks if the interface exists on dbus and is valid. If not, it displays a dialog asking user what to do (see screenshot). It can also remember the preference. Please also check spelling/grammar of the text.


Diffs (updated)
-----

  main-widget.h 313f74f 
  main-widget.cpp 28c2d9a 

Diff: http://git.reviewboard.kde.org/r/101918/diff


Testing
-------

Tested both with plasmoid active and not active, works as expected.


Screenshots
-----------

The quit dialog
  http://git.reviewboard.kde.org/r/101918/s/194/


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110713/aa43cfbf/attachment.htm 


More information about the KDE-Telepathy mailing list