Review Request: DBus check for plasmoid (aka "Do you want to go offline?" dialog)

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101918/#review4612
-----------------------------------------------------------



main-widget.h
<http://git.reviewboard.kde.org/r/101918/#comment4035>

    really try and make an effort to think if something should be public or not.
    
    Changing behaviour from the parent (which I assume is predicted) seems wrong unless you have a reason.



main-widget.cpp
<http://git.reviewboard.kde.org/r/101918/#comment4036>

    If you can create something on the stack (which you can in this case)
    
    i.e "KDialog noPlasmoidDialog"
    instead of "KDialog* noPlasmoidDialog = new KDialog()" it's normally better to do so. 
    
    It's faster, and less chance of leaking anything.



main-widget.cpp
<http://git.reviewboard.kde.org/r/101918/#comment4037>

    I think we need to brainstorm this.



main-widget.cpp
<http://git.reviewboard.kde.org/r/101918/#comment4038>

    Should it save their preference if they click "Stay Online"? I think so.



main-widget.cpp
<http://git.reviewboard.kde.org/r/101918/#comment4039>

    typo in config key name.
    "clsoing"



main-widget.cpp
<http://git.reviewboard.kde.org/r/101918/#comment4040>

    typo also here.



main-widget.cpp
<http://git.reviewboard.kde.org/r/101918/#comment4041>

    foreach (const Tp::AccountPtr &account)
    
    note the & for dealing with references, not copying the AccountPtr object.


- David


On July 11, 2011, 7:44 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101918/
> -----------------------------------------------------------
> 
> (Updated July 11, 2011, 7:44 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This is the second part of the DBus-plasmoid-check patch. It checks if the interface exists on dbus and is valid. If not, it displays a dialog asking user what to do (see screenshot). It can also remember the preference. Please also check spelling/grammar of the text.
> 
> 
> Diffs
> -----
> 
>   main-widget.h 313f74f 
>   main-widget.cpp 28c2d9a 
> 
> Diff: http://git.reviewboard.kde.org/r/101918/diff
> 
> 
> Testing
> -------
> 
> Tested both with plasmoid active and not active, works as expected.
> 
> 
> Screenshots
> -----------
> 
> The quit dialog
>   http://git.reviewboard.kde.org/r/101918/s/194/
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110711/d6b9c070/attachment.htm