Review Request: Export dataengine refCount on dbus

Martin Klapetek martin.klapetek at gmail.com
Mon Jul 11 21:36:14 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101858/
-----------------------------------------------------------

(Updated July 11, 2011, 7:36 p.m.)


Review request for Telepathy.


Changes
-------

Added object unregistration in destructor. Now it works properly with contact list.


Summary
-------

This simple patch adds a simple dbus adaptor to the dataengine, so it can be checked if the plasmoid is in use (the dataengine is created only with the plasmoid, when not needed, it is deleted). Next part will be checking from contact list for this dbus entry/method. It is meant as a temp workaround for bug 270675, once the upstream has proper features, we will remove it.


This addresses bug 270675.
    http://bugs.kde.org/show_bug.cgi?id=270675


Diffs (updated)
-----

  presence.h 9b199c0 
  presence.cpp 34fa5ea 

Diff: http://git.reviewboard.kde.org/r/101858/diff


Testing
-------

Added the plasmoid, dbus interface was created, removed the plasmoid, dbus interface gets removed (though the path still stays, but the method is not valid anymore).


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110711/4f300259/attachment.htm 


More information about the KDE-Telepathy mailing list