Review Request: Fix previous "Detach Tabs" patch

Francesco Nwokeka francesco.nwokeka at gmail.com
Sat Jul 9 14:28:07 CEST 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101899/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

This patch consists in a tidy-up of the previous patch and the elimination of unused methods, logic and the tidy up of some methods and functionality.
Added comments to code as well.
The aim of this patch is to keep the code as tidy and simple as possible.


Diffs
-----

  app/chat-tab.h 408bb91 
  app/chat-tab.cpp 018868e 
  app/chat-window.h a46e41b 
  app/chat-window.cpp 28905fa 
  app/telepathy-chat-ui.h ad6809f 
  app/telepathy-chat-ui.cpp 71ac4ee 

Diff: http://git.reviewboard.kde.org/r/101899/diff


Testing
-------

Created more than one chat forcing the creation in one window, detached, closed, reopened and all went well.


Thanks,

Francesco

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110709/08166dce/attachment.htm 


More information about the KDE-Telepathy mailing list