Review Request: Export dataengine refCount on dbus

[Martin Klapetek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101858/
-----------------------------------------------------------

(Updated July 7, 2011, 6:40 p.m.)


Review request for Telepathy.


Changes
-------

Updated as discussed

The only issue with this is that qdbusviewer still finds this path after the dataengine is gone, although the registered object /PresenceEngineActive is not among the displayed methods. Hopefully this will work from the contact list side.


Summary
-------

This simple patch adds a simple dbus adaptor to the dataengine, so it can be checked if the plasmoid is in use (the dataengine is created only with the plasmoid, when not needed, it is deleted). Next part will be checking from contact list for this dbus entry/method. It is meant as a temp workaround for bug 270675, once the upstream has proper features, we will remove it.


This addresses bug 270675.
    http://bugs.kde.org/show_bug.cgi?id=270675


Diffs (updated)
-----

  presence.h 9b199c0 
  presence.cpp 34fa5ea 

Diff: http://git.reviewboard.kde.org/r/101858/diff


Testing
-------

Added the plasmoid, dbus interface was created, removed the plasmoid, dbus interface gets removed (though the path still stays, but the method is not valid anymore).


Thanks,

Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110707/382edaa3/attachment.htm