Review Request: Allow tabs to be dettached from window

[Lasath Fernando]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101862/
-----------------------------------------------------------

(Updated July 6, 2011, 5:55 p.m.)


Review request for Telepathy.


Changes
-------

Made all the suggested changes. 
Added Icons to the actions in the context menu.
Created option in ktelepathyrc for new tab behaviour.

And some more things I'm too braindead to remember at 2AM...  

(all pushed to my clone btw)


Summary
-------

Okay, internet's really sketchy here - I don't have time to type a long description. 

I'm not sure I handled the result from KMenu::exec() right, but apart form that my changes *should* be fairly straightforward in the diff.

http://quickgit.kde.org/?p=clones%2Ftelepathy-chat-handler%2Ffernando%2FdetachableTabs.git&a=shortlog&h=refs/heads/refractored_tabs


Diffs (updated)
-----

  app/chat-tab.h 2175fe2 
  app/chat-tab.cpp 23c912e 
  app/chat-window.h 2b2b70d 
  app/chat-window.cpp 517b694 
  app/telepathy-chat-ui.h 306912d 
  app/telepathy-chat-ui.cpp 1654a9d 

Diff: http://git.reviewboard.kde.org/r/101862/diff


Testing
-------

Detached a few conversations with friends. 


Thanks,

Lasath

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110706/2bf0aff7/attachment.htm