Review Request: Export dataengine refCount on dbus

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101858/#review4409
-----------------------------------------------------------



presence.h
<http://git.reviewboard.kde.org/r/101858/#comment3708>

    m_ is normally for member variables
    s_ for static.



presence.cpp
<http://git.reviewboard.kde.org/r/101858/#comment3709>

    This isn't really ref counting.
    
    It will say how many of this type of object are in the system, not count how many pointers there are to this one instance. (actual ref counting)
    
    Anyway, I'd be very surprised if plasma worked this way. I'm pretty sure if an other plasmoid starts using it, it will increase the ref count of the dataengine and NOT call the constructor again.
    
    I would suggest looking where the parent class has it's ref counter increased.
    
    (arguably this will work to tell if the dataengine exists or not.. which is probably actually all that's needed in reality.)
    
    tl;dr pretty sure this won't work. Happy to be proved wrong if you have evidence otherwise.
    
    


- David


On July 5, 2011, 7:15 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101858/
> -----------------------------------------------------------
> 
> (Updated July 5, 2011, 7:15 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This simple patch adds a simple dbus adaptor to the dataengine, so it can be checked if the plasmoid is in use (the dataengine is created only with the plasmoid, when not needed, it is deleted). Next part will be checking from contact list for this dbus entry/method. It is meant as a temp workaround for bug 270675, once the upstream has proper features, we will remove it.
> 
> 
> This addresses bug 270675.
>     http://bugs.kde.org/show_bug.cgi?id=270675
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 69b839a 
>   presence.h 9b199c0 
>   presence.cpp 34fa5ea 
> 
> Diff: http://git.reviewboard.kde.org/r/101858/diff
> 
> 
> Testing
> -------
> 
> Added the plasmoid, dbus interface was created, removed the plasmoid, dbus interface gets removed (though the path still stays, but the method is not valid anymore).
> 
> 
> Thanks,
> 
> Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110705/bbff73b1/attachment-0001.htm