Review Request: Make proxy-tree-node safer. Should hopefully avoid accessing source node after it's deleted.
Martin Klapetek
martin.klapetek at gmail.com
Sat Jul 2 12:49:16 CEST 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101821/#review4311
-----------------------------------------------------------
Ship it!
We should probably also disconnect all the signals from sourceNode, just to be super-extra-sure.
- Martin
On July 1, 2011, 11:16 p.m., David Edmundson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101821/
> -----------------------------------------------------------
>
> (Updated July 1, 2011, 11:16 p.m.)
>
>
> Review request for Telepathy.
>
>
> Summary
> -------
>
> Make proxy-tree-node safer. Should hopefully avoid accessing source node after it's deleted.
>
>
> Diffs
> -----
>
> models/proxy-tree-node.cpp PRE-CREATION
>
> Diff: http://git.reviewboard.kde.org/r/101821/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> David
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110702/44a854d0/attachment.htm
More information about the KDE-Telepathy
mailing list