Review Request: Fix group chat crash + debug info for deliveryReport

[Francesco Nwokeka]

> On July 2, 2011, 1:21 a.m., David Edmundson wrote:
> > lib/chat-widget.cpp, line 534
> > <http://git.reviewboard.kde.org/r/101822/diff/1/?file=25815#file25815line534>
> >
> >     I would much rather use (message.sender()==0)
> >     
> >     That way we catch 1-1 cases where sender is zero, and use all the information available if some group chats do have all the information (like MSN may well be)
> 
> Francesco Nwokeka wrote:
>     would it be better to do : "if (isGroupChat || message.sender() == 0)" ?
> 
> David Edmundson wrote:
>     why?
>     If we have a sender object, lets use all the information we have.

good point.


- Francesco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/101822/#review4299
-----------------------------------------------------------


On July 2, 2011, 1:08 a.m., Francesco Nwokeka wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/101822/
> -----------------------------------------------------------
> 
> (Updated July 2, 2011, 1:08 a.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> This patch fixes a chat handler crash when in a group chat because "sender" was null. It also adds info from delivery reports
> 
> 
> Diffs
> -----
> 
>   app/main.cpp 4f47e18 
>   lib/chat-widget.cpp d427ac1 
> 
> Diff: http://git.reviewboard.kde.org/r/101822/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Francesco
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110702/43dd1ee0/attachment.htm