Review Request: sofiasip plugin for telepathy-accounts-kcm

[Florian Reinhard]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100444/
-----------------------------------------------------------

(Updated Jan. 29, 2011, 11:58 a.m.)


Review request for Telepathy.


Changes
-------

fixed all issues mentioned (and a bit more).


Summary
-------

the following telepathy-sofiasip parameters are implemented:
account
password
alias

stun-server
stun-port
discover-stun
discover-binding
loose-routing
keepalive-mechanism
keepalive-interval


these are missing atm:
proxy-host
port
transport

registrar
immutable-streams
local-ip-address
local-port
extra-auth-user
extra-auth-password


Diffs (updated)
-----

  CMakeLists.txt 9aec0ecf2243e302d3cd01f1c4bd246f6e248305 
  sofiasip/CMakeLists.txt PRE-CREATION 
  sofiasip/Messages.sh PRE-CREATION 
  sofiasip/kcmtelepathyaccounts_plugin_sofiasip.desktop PRE-CREATION 
  sofiasip/sofiasip-account-ui-plugin.h PRE-CREATION 
  sofiasip/sofiasip-account-ui-plugin.cpp PRE-CREATION 
  sofiasip/sofiasip-account-ui.h PRE-CREATION 
  sofiasip/sofiasip-account-ui.cpp PRE-CREATION 
  sofiasip/sofiasip-advanced-options-widget.h PRE-CREATION 
  sofiasip/sofiasip-advanced-options-widget.cpp PRE-CREATION 
  sofiasip/sofiasip-advanced-options-widget.ui PRE-CREATION 
  sofiasip/sofiasip-main-options-widget.h PRE-CREATION 
  sofiasip/sofiasip-main-options-widget.cpp PRE-CREATION 
  sofiasip/sofiasip-main-options-widget.ui PRE-CREATION 

Diff: http://git.reviewboard.kde.org/r/100444/diff


Testing
-------

add new account
edit existing account
connect


Screenshots
-----------

Main Options and Advanced Options
  http://git.reviewboard.kde.org/r/100444/s/55/


Thanks,

Florian

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110129/8478391c/attachment.htm