Review Request: Implement reading handler preferences from a configuration file in tp-approver

George Kiagiadakis kiagiadakis.george at gmail.com
Thu Jan 27 20:31:38 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100450/
-----------------------------------------------------------

(Updated Jan. 27, 2011, 7:31 p.m.)


Review request for Telepathy.


Changes
-------

Update: also install a configuration file that provides default handler preferences for kde.


Summary
-------

This patch allows tp-kde-approver to read handler preferences from a configuration file. The UI for configuring them does not yet exist, but it works if you manually edit the config file.


Diffs (updated)
-----

  src/CMakeLists.txt b1c062f9394c61aeff4adb711a9122d78687e929 
  src/handlewithcaller.h 1e026a6bad0e7140cb4be7e8ea9578bfa17ce4e3 
  src/handlewithcaller.cpp 659a867f48e46c6acd4ddbfd68b9cfedb63d1d7f 
  src/telepathy_kde_approverrc PRE-CREATION 
  src/textchannelapprover.cpp c0d1585e01c0f1ace9a59eb8c6d45d794fff385a 
  src/tpkdeapproverfactory.h PRE-CREATION 
  src/tpkdeapprovermodule.cpp 7df6f5ce5cf51ba89932b86b09f88a4ac634b38c 

Diff: http://git.reviewboard.kde.org/r/100450/diff


Testing
-------

With both empathy and tp-kde-chat-handler installed, I set the preferred handler to be the kde one and the approver did the right thing.


Thanks,

George

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110127/68b11321/attachment.htm 


More information about the KDE-Telepathy mailing list