Review Request: Small changes on tp-approver (fixes to comments from the previous review request)

George Kiagiadakis kiagiadakis.george at gmail.com
Thu Jan 27 17:48:10 CET 2011


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100448/
-----------------------------------------------------------

Review request for Telepathy.


Summary
-------

shortlog:
George Kiagiadakis (4):
      Make ApproverDaemon a proper QObject.
      Count the number of channels instead of the number of messages on the tooltip.
      Use only one notification and update the text in it, instead of spawning a new notification each time.
      Remove the contact upgrade hack, since tp-qt4 >= 0.5.3 implements contact factories.


Diffs
-----

  CMakeLists.txt a0a16065477fcc9813da2f255b0cc0cbd440f117 
  src/approverdaemon.h 2cee00e6b46c8685b5e29eec390b8ba85e2b2f0e 
  src/approverdaemon.cpp 30681453dbf1818b539ad152b689336e6b2d3407 
  src/textchannelapprover.h ef3a6a25cb6c07d512ebde5bb0c1b742608ad524 
  src/textchannelapprover.cpp c0d1585e01c0f1ace9a59eb8c6d45d794fff385a 

Diff: http://git.reviewboard.kde.org/r/100448/diff


Testing
-------

tested, works fine.


Thanks,

George

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110127/60f3c2c2/attachment.htm 


More information about the KDE-Telepathy mailing list