Review Request: sofiasip plugin for telepathy-accounts-kcm

[Thomas Richard]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100444/#review1070
-----------------------------------------------------------


Looks good except for a few small comments.


sofiasip/sofiasip-account-ui-plugin.cpp
<http://git.reviewboard.kde.org/r/100444/#comment863>

    Remove spaces when you want to add a whitespace. Here and in other places



sofiasip/sofiasip-account-ui.cpp
<http://git.reviewboard.kde.org/r/100444/#comment864>

    Blahblah doesn't look that good to me :p



sofiasip/sofiasip-advanced-options-widget.cpp
<http://git.reviewboard.kde.org/r/100444/#comment860>

    Please delete unused code



sofiasip/sofiasip-advanced-options-widget.cpp
<http://git.reviewboard.kde.org/r/100444/#comment861>

    Same here



sofiasip/sofiasip-advanced-options-widget.cpp
<http://git.reviewboard.kde.org/r/100444/#comment865>

    You should delete d->ui too



sofiasip/sofiasip-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100444/#comment862>

    Code style:
    if(condition) {
    ...
    }



sofiasip/sofiasip-main-options-widget.cpp
<http://git.reviewboard.kde.org/r/100444/#comment866>

    You should delete d->ui too


- Thomas


On Jan. 26, 2011, 4:48 p.m., Florian Reinhard wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100444/
> -----------------------------------------------------------
> 
> (Updated Jan. 26, 2011, 4:48 p.m.)
> 
> 
> Review request for Telepathy.
> 
> 
> Summary
> -------
> 
> the following telepathy-sofiasip parameters are implemented:
> account
> password
> alias
> 
> stun-server
> stun-port
> discover-stun
> discover-binding
> loose-routing
> keepalive-mechanism
> keepalive-interval
> 
> 
> these are missing atm:
> proxy-host
> port
> transport
> 
> registrar
> immutable-streams
> local-ip-address
> local-port
> extra-auth-user
> extra-auth-password
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9aec0ecf2243e302d3cd01f1c4bd246f6e248305 
>   sofiasip/CMakeLists.txt PRE-CREATION 
>   sofiasip/Messages.sh PRE-CREATION 
>   sofiasip/kcmtelepathyaccounts_plugin_sofiasip.desktop PRE-CREATION 
>   sofiasip/sofiasip-account-ui-plugin.h PRE-CREATION 
>   sofiasip/sofiasip-account-ui-plugin.cpp PRE-CREATION 
>   sofiasip/sofiasip-account-ui.h PRE-CREATION 
>   sofiasip/sofiasip-account-ui.cpp PRE-CREATION 
>   sofiasip/sofiasip-advanced-options-widget.h PRE-CREATION 
>   sofiasip/sofiasip-advanced-options-widget.cpp PRE-CREATION 
>   sofiasip/sofiasip-advanced-options-widget.ui PRE-CREATION 
>   sofiasip/sofiasip-main-options-widget.h PRE-CREATION 
>   sofiasip/sofiasip-main-options-widget.cpp PRE-CREATION 
>   sofiasip/sofiasip-main-options-widget.ui PRE-CREATION 
> 
> Diff: http://git.reviewboard.kde.org/r/100444/diff
> 
> 
> Testing
> -------
> 
> add new account
> edit existing account
> connect
> 
> 
> Screenshots
> -----------
> 
> Main Options and Advanced Options
>   http://git.reviewboard.kde.org/r/100444/s/55/
> 
> 
> Thanks,
> 
> Florian
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kde-telepathy/attachments/20110126/c222b3ed/attachment-0001.htm